Remove Compiler.reportFatalError.

Remove Compiler.reportFatalError.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42678

[ahe, 2014-12-19 17:38:19]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2014-12-19 17:38:19]

So far co19 and language tests pass with this.

Dramatically cuts down on the number of fatal errors, and prevents introductions
of new.

[ahe, 2014-12-20 05:42:15]

All tests dart2js/d8 tests are passing now. I still have three unexpected
failures in tests/compiler/dart2js.

[ahe, 2015-01-05 14:49:19]

PTAL

[ahe, 2015-01-05 14:49:33]

On 2015/01/05 14:49:19, ahe wrote:
> PTAL

I meant "ping" :-)

[Johnni Winther, 2015-01-06 08:12:05]

lgtm

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/apiimpl.dart:315: throw new
CompilerCancelledException(null);
Insert a TODO. This shouldn't be fatal, but behave like an unresolved import.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/compile_time_constants.dart:138: throw new
CompilerCancelledException(null);
Insert a TODO. This should only mark the currently computed constants as
invalid, but otherwise continue.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/compile_time_constants.dart:663: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/elements/modelx.dart:498: throw new
CompilerCancelledException(null);
Add a TODO to let us continue the compilation.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:1415: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:2240: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:2246: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:2277: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:4925: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:4928: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/resolution/signatures.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/signatures.dart:181: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/signatures.dart:190: throw new
CompilerCancelledException(null);
Ditto.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/scanner/listener.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/scanner/listener.dart:1466: void
reportFatalError(Spannable spannable,
Maybe deprecate this method.

[ahe, 2015-01-07 12:55:24]

PTAL.

Will create another CL which address the issues in unittests.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/apiimpl.dart:315: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Insert a TODO. This shouldn't be fatal, but behave like an unresolved import.

Actually, this is a misuse of the compiler API. I've tried making this more
obvious in https://codereview.chromium.org/838773002/.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/compile_time_constants.dart:138: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Insert a TODO. This should only mark the currently computed constants as
> invalid, but otherwise continue.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/compile_time_constants.dart:663: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/elements/modelx.dart:498: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Add a TODO to let us continue the compilation.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:1415: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:05, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:2240: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:2246: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:2277: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:05, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:4925: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/members.dart:4928: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:04, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/resolution/signatures.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/signatures.dart:181: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:05, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/resolution/signatures.dart:190: throw new
CompilerCancelledException(null);
On 2015/01/06 08:12:05, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
File dart/pkg/compiler/lib/src/scanner/listener.dart (right):

https://codereview.chromium.org/791263003/diff/20001/dart/pkg/compiler/lib/sr...
dart/pkg/compiler/lib/src/scanner/listener.dart:1466: void
reportFatalError(Spannable spannable,
On 2015/01/06 08:12:05, Johnni Winther wrote:
> Maybe deprecate this method.

I don't think this should be deprecated, there are times when there is no other
option than to abort the parser.

[ahe, 2015-01-07 15:22:51]

The CL which fixes the unit tests is:

https://codereview.chromium.org/836313002/

[Johnni Winther, 2015-01-08 08:19:48]

Still LGTM

[ahe, 2015-01-08 08:37:35]

Committed patchset #4 (id:60001) manually as 42678 (presubmit successful).