Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 836313002: Remove dependencies on reportFatalError from tests. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Remove dependencies on reportFatalError from tests. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -274 lines) Patch
M dart/tests/compiler/dart2js/exit_code_test.dart View 1 chunk +267 lines, -266 lines 0 comments Download
M dart/tests/compiler/dart2js/mock_compiler.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js/resolver_test.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ahe
Requires https://codereview.chromium.org/791263003/ and https://codereview.chromium.org//838773002
5 years, 11 months ago (2015-01-07 15:23:15 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-08 08:19:56 UTC) #3
ahe
5 years, 11 months ago (2015-01-08 08:38:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698