Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: dart/pkg/compiler/lib/src/resolution/signatures.dart

Issue 791263003: Remove Compiler.reportFatalError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Restore code I accidentally removed. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/pkg/compiler/lib/src/resolution/members.dart ('k') | dart/pkg/compiler/lib/src/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/compiler/lib/src/resolution/signatures.dart
diff --git a/dart/pkg/compiler/lib/src/resolution/signatures.dart b/dart/pkg/compiler/lib/src/resolution/signatures.dart
index 8b31d43489f7aae62ec4bf744aca4e6e21a45c7e..26d2326ed527b69e5530b529969a921799f81997 100644
--- a/dart/pkg/compiler/lib/src/resolution/signatures.dart
+++ b/dart/pkg/compiler/lib/src/resolution/signatures.dart
@@ -178,6 +178,8 @@ class SignatureResolver extends MappingVisitor<FormalElementX> {
} else if (!identical(enclosingElement.kind,
ElementKind.GENERATIVE_CONSTRUCTOR)) {
error(node, MessageKind.INITIALIZING_FORMAL_NOT_ALLOWED);
+ // TODO(ahe): Don't throw, recover from error.
+ throw new CompilerCancelledException(null);
} else {
Identifier name = getParameterName(node);
validateName(name);
@@ -186,6 +188,8 @@ class SignatureResolver extends MappingVisitor<FormalElementX> {
if (fieldElement == null ||
!identical(fieldElement.kind, ElementKind.FIELD)) {
error(node, MessageKind.NOT_A_FIELD, {'fieldName': name});
+ // TODO(ahe): Don't throw, recover from error.
+ throw new CompilerCancelledException(null);
} else if (!fieldElement.isInstanceMember) {
error(node, MessageKind.NOT_INSTANCE_FIELD, {'fieldName': name});
}
« no previous file with comments | « dart/pkg/compiler/lib/src/resolution/members.dart ('k') | dart/pkg/compiler/lib/src/scanner/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698