Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 787653002: remove unused cache arguments (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -39 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +6 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_manager_test.dart View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years ago (2014-12-08 13:55:36 UTC) #2
scheglov
LGTM
6 years ago (2014-12-08 15:59:11 UTC) #3
danrubel
6 years ago (2014-12-08 16:59:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698