Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 787653002: remove unused cache arguments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
index 11b1e24ac385405830c496fc9ca9a5d2b689b08f..42c7b6f41bdc54021ea879b9d669f4b3d6da50f1 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
@@ -67,17 +67,12 @@ class DartCompletionManager extends CompletionManager {
* Create a new initialized Dart source completion manager
*/
factory DartCompletionManager.create(AnalysisContext context,
- SearchEngine searchEngine, Source source, CompletionCache oldCache) {
- DartCompletionCache newCache;
- if (oldCache is DartCompletionCache) {
- if (oldCache.context == context && oldCache.source == source) {
- newCache = oldCache;
- }
- }
- if (newCache == null) {
- newCache = new DartCompletionCache(context, source);
- }
- return new DartCompletionManager(context, searchEngine, source, newCache);
+ SearchEngine searchEngine, Source source) {
+ return new DartCompletionManager(
+ context,
+ searchEngine,
+ source,
+ new DartCompletionCache(context, source));
}
@override

Powered by Google App Engine
This is Rietveld 408576698