pkg/analysis_server/lib/src/services/completion/completion_manager.dart - Issue 787653002: remove unused cache arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 787653002: remove unused cache arguments (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/domain_completion.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart

index 1717678156371d6b78948fcc719d44872ec7fbe2..4ffb40b4c50ec302c70c8684cd688897d261d405 100644

--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart

@@ -57,14 +57,10 @@ abstract class CompletionManager {

* Create a manager for the given request.

factory CompletionManager.create(AnalysisContext context, Source source,

- SearchEngine searchEngine, CompletionCache cache) {

+ SearchEngine searchEngine) {

if (context != null) {

if (AnalysisEngine.isDartFileName(source.shortName)) {

- return new DartCompletionManager.create(

- context,

- searchEngine,

- source,

- cache);

+ return new DartCompletionManager.create(context, searchEngine, source);

}

if (AnalysisEngine.isHtmlFileName(source.shortName)) {

//TODO (danrubel) implement