Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 787603004: Getters should not have parameters. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Getters should not have parameters. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Element.java View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-08 20:32:19 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-08 21:01:09 UTC) #2
scheglov
6 years ago (2014-12-08 21:04:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698