pkg/analysis_server/lib/src/computer/computer_outline.dart - Issue 787603004: Getters should not have parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/computer/computer_outline.dart

Issue 787603004: Getters should not have parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/computer/computer_outline.dart

diff --git a/pkg/analysis_server/lib/src/computer/computer_outline.dart b/pkg/analysis_server/lib/src/computer/computer_outline.dart

index bb1604777d2738d4d174a2bbad7a7e2104022417..03d8a898f5b672263d8317ad2ac13d6fd751b849 100644

--- a/pkg/analysis_server/lib/src/computer/computer_outline.dart

+++ b/pkg/analysis_server/lib/src/computer/computer_outline.dart

@@ -298,7 +298,7 @@ class DartUnitOutlineComputer {

kind = ElementKind.METHOD;

}

_SourceRegion sourceRegion = _getSourceRegion(method);

- String parametersStr = parameters != null ? parameters.toSource() : '';

+ String parametersStr = parameters != null ? parameters.toSource() : null;

String returnTypeStr = returnType != null ? returnType.toSource() : '';

Element element = new Element(

kind,