Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: pkg/analysis_server/lib/src/computer/computer_outline.dart

Issue 787603004: Getters should not have parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/analysis_server/doc/api.html ('k') | pkg/analysis_server/lib/src/generated_protocol.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library computer.outline; 5 library computer.outline;
6 6
7 import 'package:analysis_server/src/collections.dart'; 7 import 'package:analysis_server/src/collections.dart';
8 import 'package:analysis_server/src/protocol.dart'; 8 import 'package:analysis_server/src/protocol.dart';
9 import 'package:analyzer/src/generated/ast.dart'; 9 import 'package:analyzer/src/generated/ast.dart';
10 import 'package:analyzer/src/generated/element.dart' as engine; 10 import 'package:analyzer/src/generated/element.dart' as engine;
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 FormalParameterList parameters = method.parameters; 291 FormalParameterList parameters = method.parameters;
292 ElementKind kind; 292 ElementKind kind;
293 if (method.isGetter) { 293 if (method.isGetter) {
294 kind = ElementKind.GETTER; 294 kind = ElementKind.GETTER;
295 } else if (method.isSetter) { 295 } else if (method.isSetter) {
296 kind = ElementKind.SETTER; 296 kind = ElementKind.SETTER;
297 } else { 297 } else {
298 kind = ElementKind.METHOD; 298 kind = ElementKind.METHOD;
299 } 299 }
300 _SourceRegion sourceRegion = _getSourceRegion(method); 300 _SourceRegion sourceRegion = _getSourceRegion(method);
301 String parametersStr = parameters != null ? parameters.toSource() : ''; 301 String parametersStr = parameters != null ? parameters.toSource() : null;
302 String returnTypeStr = returnType != null ? returnType.toSource() : ''; 302 String returnTypeStr = returnType != null ? returnType.toSource() : '';
303 Element element = new Element( 303 Element element = new Element(
304 kind, 304 kind,
305 name, 305 name,
306 Element.makeFlags( 306 Element.makeFlags(
307 isPrivate: Identifier.isPrivateName(name), 307 isPrivate: Identifier.isPrivateName(name),
308 isDeprecated: _isDeprecated(method), 308 isDeprecated: _isDeprecated(method),
309 isAbstract: method.isAbstract, 309 isAbstract: method.isAbstract,
310 isStatic: method.isStatic), 310 isStatic: method.isStatic),
311 location: _getLocationNode(nameNode), 311 location: _getLocationNode(nameNode),
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 382
383 /** 383 /**
384 * A range of characters. 384 * A range of characters.
385 */ 385 */
386 class _SourceRegion { 386 class _SourceRegion {
387 final int length; 387 final int length;
388 final int offset; 388 final int offset;
389 _SourceRegion(this.offset, this.length); 389 _SourceRegion(this.offset, this.length);
390 } 390 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/doc/api.html ('k') | pkg/analysis_server/lib/src/generated_protocol.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698