Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 768553002: Add support for (unintercepted) method calls to the cps js emitter. (Closed)

Created:
6 years ago by sigurdm
Modified:
6 years ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Add support for (unintercepted) method calls to the cps js emitter. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42022

Patch Set 1 : #

Total comments: 2

Patch Set 2 : move jsPropertyCall to js builder. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -20 lines) Patch
M pkg/compiler/lib/src/js/builder.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 1 chunk +18 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 7 chunks +10 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_basic.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sigurdm
6 years ago (2014-11-27 12:28:21 UTC) #4
floitsch
LGTM. https://codereview.chromium.org/768553002/diff/40001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/768553002/diff/40001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode210 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:210: js.Call jsPropertyCall(js.Expression receiver, Maybe move this to the ...
6 years ago (2014-11-27 13:20:12 UTC) #6
sigurdm
ptal https://codereview.chromium.org/768553002/diff/40001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/768553002/diff/40001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode210 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:210: js.Call jsPropertyCall(js.Expression receiver, On 2014/11/27 13:20:12, floitsch wrote: ...
6 years ago (2014-11-27 14:31:18 UTC) #7
floitsch
LGTM.
6 years ago (2014-11-27 14:40:49 UTC) #8
sigurdm
6 years ago (2014-11-27 14:54:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) manually as 42022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698