Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 768553002: Add support for (unintercepted) method calls to the cps js emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: move jsPropertyCall to js builder. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index a08610005cf5dc3df69ef963d1ab58379f8cf55c..fa1ea1f83da5d4cfcd93e708f69d35dbdabda863 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -1490,13 +1490,6 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
}
- js.Call jsPropertyCall(js.Expression receiver,
- String fieldName,
- List<js.Expression> arguments) {
- return new js.Call(new js.PropertyAccess.field(receiver, fieldName),
- arguments);
- }
-
void visitInterceptor(HInterceptor node) {
registry.registerSpecializedGetInterceptor(node.interceptedClasses);
String name = backend.namer.getInterceptorName(
@@ -1505,7 +1498,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
backend.namer.globalObjectFor(backend.interceptorsLibrary));
use(node.receiver);
List<js.Expression> arguments = <js.Expression>[pop()];
- push(jsPropertyCall(isolate, name, arguments), node);
+ push(js.propertyCall(isolate, name, arguments), node);
registry.registerUseInterceptor();
}
@@ -1540,7 +1533,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
methodName = backend.namer.invocationName(node.selector);
registerMethodInvoke(node);
}
- push(jsPropertyCall(object, methodName, arguments), node);
+ push(js.propertyCall(object, methodName, arguments), node);
}
void visitInvokeConstructorBody(HInvokeConstructorBody node) {
@@ -1548,7 +1541,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
js.Expression object = pop();
String methodName = backend.namer.getNameOfInstanceMember(node.element);
List<js.Expression> arguments = visitArguments(node.inputs);
- push(jsPropertyCall(object, methodName, arguments), node);
+ push(js.propertyCall(object, methodName, arguments), node);
registry.registerStaticUse(node.element);
}
@@ -1558,7 +1551,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
backend.namer.globalObjectFor(backend.interceptorsLibrary));
Selector selector = getOptimizedSelectorFor(node, node.selector);
String methodName = backend.registerOneShotInterceptor(selector);
- push(jsPropertyCall(isolate, methodName, arguments), node);
+ push(js.propertyCall(isolate, methodName, arguments), node);
if (selector.isGetter) {
registerGetter(node);
} else if (selector.isSetter) {
@@ -1615,23 +1608,23 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
visitInvokeDynamicSetter(HInvokeDynamicSetter node) {
use(node.receiver);
String name = backend.namer.invocationName(node.selector);
- push(jsPropertyCall(pop(), name, visitArguments(node.inputs)), node);
+ push(js.propertyCall(pop(), name, visitArguments(node.inputs)), node);
registerSetter(node);
}
visitInvokeDynamicGetter(HInvokeDynamicGetter node) {
use(node.receiver);
String name = backend.namer.invocationName(node.selector);
- push(jsPropertyCall(pop(), name, visitArguments(node.inputs)), node);
+ push(js.propertyCall(pop(), name, visitArguments(node.inputs)), node);
registerGetter(node);
}
visitInvokeClosure(HInvokeClosure node) {
Selector call = new Selector.callClosureFrom(node.selector);
use(node.receiver);
- push(jsPropertyCall(pop(),
- backend.namer.invocationName(call),
- visitArguments(node.inputs)),
+ push(js.propertyCall(pop(),
+ backend.namer.invocationName(call),
+ visitArguments(node.inputs)),
node);
registry.registerDynamicInvocation(call);
}
@@ -2586,7 +2579,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
use(node.checkedInput);
String methodName =
backend.namer.invocationName(node.receiverTypeCheckSelector);
- js.Expression call = jsPropertyCall(pop(), methodName, []);
+ js.Expression call = js.propertyCall(pop(), methodName, []);
pushStatement(new js.Return(call));
}
currentContainer = oldContainer;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/glue.dart ('k') | tests/compiler/dart2js/js_backend_cps_ir_basic.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698