Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 768553002: Add support for (unintercepted) method calls to the cps js emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: move jsPropertyCall to js builder. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js/builder.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 67203061c4ba74b5f07c55a903933888fc4232bf..ec9ff8d303853f0cc3b7d224b10b80ae76237691 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -185,10 +185,26 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
return buildStaticInvoke(node.selector, node.target, node.arguments);
}
+ void registerMethodInvoke(tree_ir.InvokeMethod node) {
+ Selector selector = node.selector;
+ // TODO(sigurdm): We should find a better place to register the call.
+ Selector call = new Selector.callClosureFrom(selector);
+ registry.registerDynamicInvocation(call);
+ registry.registerDynamicInvocation(selector);
+ }
+
@override
js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
- return giveup(node);
- // TODO: implement visitInvokeMethod
+ // TODO(sigurdm): Handle intercepted invocations.
+ if (glue.isIntercepted(node.selector)) giveup(node);
+ js.Expression receiver = visitExpression(node.receiver);
+
+ List<js.Expression> arguments = visitArguments(node.arguments);
+
+ String methodName = glue.invocationName(node.selector);
+ registerMethodInvoke(node);
+
+ return js.propertyCall(receiver, methodName, arguments);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/js/builder.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698