Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 745583003: Address comments from CL 739513002. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r41906. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 3 chunks +10 lines, -10 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 2 chunks +40 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ahe
6 years, 1 month ago (2014-11-21 10:47:08 UTC) #2
Johnni Winther
lgtm
6 years, 1 month ago (2014-11-21 12:29:53 UTC) #3
ahe
6 years, 1 month ago (2014-11-21 16:13:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41907 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698