Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: dart/tests/try/web/incremental_compilation_update_test.dart

Issue 745583003: Address comments from CL 739513002. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r41906. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/pkg/dart2js_incremental/lib/library_updater.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/try/web/incremental_compilation_update_test.dart
diff --git a/dart/tests/try/web/incremental_compilation_update_test.dart b/dart/tests/try/web/incremental_compilation_update_test.dart
index 5a8d37136bd1933c82395cc00fdb6f04df3954da..cb93efeb749b0b7bf9f9cf965af4b98d13c7e803 100644
--- a/dart/tests/try/web/incremental_compilation_update_test.dart
+++ b/dart/tests/try/web/incremental_compilation_update_test.dart
@@ -814,9 +814,7 @@ main() {
const <String>['v2']),
],
- // Test that removing a class is supported.
- // TODO(ahe): There should be a warning from second program, but there
- // isn't. Investigate and write test.
+ // Test that removing a class is supported, using constructor.
const <ProgramResult>[
const ProgramResult(
r"""
@@ -847,6 +845,45 @@ main() {
const <String>['v2']),
],
+ // Test that removing a class is supported, using a static method.
+ const <ProgramResult>[
+ const ProgramResult(
+ r"""
+class C {
+ static m() {
+ print('v1');
+ }
+}
+
+main() {
+ try {
+ // TODO(ahe): Incremental compiler can't handle new noSuchMethod
+ // situations, crashes when compiling a constructor which uses type
+ // arguments.
+ C.missing();
+ } catch (e) {
+ }
+ try {
+ C.m();
+ } catch (e) {
+ print('v2');
+ }
+}
+""",
+ const <String>['v1']),
+ const ProgramResult(
+ r"""
+main() {
+ try {
+ C.m();
+ } catch (e) {
+ print('v2');
+ }
+}
+""",
+ const <String>['v2']),
+ ],
+
// Test that changing the supertype of a class.
const <ProgramResult>[
const ProgramResult(
« no previous file with comments | « dart/pkg/dart2js_incremental/lib/library_updater.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698