Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: dart/pkg/dart2js_incremental/lib/library_updater.dart

Issue 745583003: Address comments from CL 739513002. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r41906. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/try/web/incremental_compilation_update_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/dart2js_incremental/lib/library_updater.dart
diff --git a/dart/pkg/dart2js_incremental/lib/library_updater.dart b/dart/pkg/dart2js_incremental/lib/library_updater.dart
index c9ce69a368ec4d58cd1959d44a44b6d4f9753748..cc29d1b9c3c7157947f2dba25035bad48e86f2fa 100644
--- a/dart/pkg/dart2js_incremental/lib/library_updater.dart
+++ b/dart/pkg/dart2js_incremental/lib/library_updater.dart
@@ -606,11 +606,12 @@ class LibraryUpdater extends JsFeatures {
statements.add(
js.statement('#.prototype.# = f', [elementAccess, name]));
- if (backend.isAliasedSuperMember(element)) {
- String superName = namer.getNameOfAliasedSuperMember(element);
- statements.add(
- js.statement('#.prototype.# = f', [elementAccess, superName]));
- }
+ // TODO(ahe): Restore when isAliasedSuperMember is restored.
+ // if (backend.isAliasedSuperMember(element)) {
+ // String superName = namer.getNameOfAliasedSuperMember(element);
+ // statements.add(
+ // js.statement('#.prototype.# = f', [elementAccess, superName]));
+ // }
} else {
jsAst.Node elementAccess = namer.elementAccess(element);
jsAst.Expression globalFunctionsAccess =
@@ -790,9 +791,10 @@ class RemovedFunctionUpdate extends RemovalUpdate
if (element.isInstanceMember) {
elementAccess = namer.elementAccess(element.enclosingClass);
name = namer.getNameOfMember(element);
- if (backend.isAliasedSuperMember(element)) {
- superName = namer.getNameOfAliasedSuperMember(element);
- }
+ // TODO(ahe): Restore when isAliasedSuperMember is restored.
+ // if (backend.isAliasedSuperMember(element)) {
+ // superName = namer.getNameOfAliasedSuperMember(element);
+ // }
} else {
elementAccess = namer.elementAccess(element);
}
@@ -841,8 +843,6 @@ class RemovedClassUpdate extends RemovalUpdate with JsFeatures {
PartialClassElement get after => null;
- bool get isRemoval => true;
-
void captureState() {
if (wasStateCaptured) throw "captureState was called twice.";
wasStateCaptured = true;
« no previous file with comments | « no previous file | dart/tests/try/web/incremental_compilation_update_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698