Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 744793002: Reland and fix bug: Don't store redundant compile-type at values. (Closed)

Created:
6 years, 1 month ago by Florian Schneider
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reland and fix bug: Don't store redundant compile-type at values. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41898

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -0 lines 1 comment Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
https://codereview.chromium.org/744793002/diff/40001/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://codereview.chromium.org/744793002/diff/40001/runtime/vm/flow_graph_compiler_ia32.cc#newcode80 runtime/vm/flow_graph_compiler_ia32.cc:80: ++builder->current_info_number_; My CL corrects the index used in compression ...
6 years, 1 month ago (2014-11-20 17:11:14 UTC) #2
Vyacheslav Egorov (Google)
lgtm
6 years, 1 month ago (2014-11-21 10:22:17 UTC) #3
Florian Schneider
6 years, 1 month ago (2014-11-21 12:04:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r41898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698