Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 744793002: Reland and fix bug: Don't store redundant compile-type at values. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 41847)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -241,6 +241,11 @@
void FlowGraphTypePropagator::VisitValue(Value* value) {
CompileType* type = TypeOf(value->definition());
+ if (type == value->definition()->Type()) {
+ value->SetReachingType(NULL);
+ return;
+ }
+
value->SetReachingType(type);
if (FLAG_trace_type_propagation) {
@@ -641,7 +646,7 @@
CompileType* Value::Type() {
if (reaching_type_ == NULL) {
- reaching_type_ = definition()->Type();
+ return definition()->Type();
}
return reaching_type_;
}

Powered by Google App Engine
This is Rietveld 408576698