runtime/vm/compiler.cc - Issue 744793002: Reland and fix bug: Don't store redundant compile-type at values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 744793002: Reland and fix bug: Don't store redundant compile-type at values. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 41847)

+++ runtime/vm/compiler.cc (working copy)

@@ -537,7 +537,12 @@

// TODO(fschneider): Support allocation sinking with try-catch.

sinking = new AllocationSinking(flow_graph);

sinking->Optimize();

+ DEBUG_ASSERT(flow_graph->VerifyUseLists());

}

+ // Recompute types after load elimination to ensure correct

+ // types for created phi-instructions.

+ FlowGraphTypePropagator::Propagate(flow_graph);

DEBUG_ASSERT(flow_graph->VerifyUseLists());

// Ensure that all phis inserted by optimization passes have consistent

« no previous file with comments | « no previous file | runtime/vm/deopt_instructions.h » ('j') | runtime/vm/flow_graph_compiler_ia32.cc » ('J')