Issue 742163002: cache import suggestions

Issue 742163002: cache import suggestions (Closed)

Created:
6 years, 1 month ago by danrubel

Modified:
6 years, 1 month ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

cache import suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41865

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+454 lines, -252 lines)			Patch
M	pkg/analysis_server/lib/driver.dart	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	pkg/analysis_server/lib/src/services/completion/completion_manager.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart	View	6 chunks	+84 lines, -23 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/imported_computer.dart	View	7 chunks	+184 lines, -131 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/arglist_computer_test.dart	View	6 chunks	+6 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/combinator_computer_test.dart	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_computer_test.dart	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_test_util.dart	View	75 chunks	+98 lines, -75 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/imported_computer_test.dart	View	2 chunks	+64 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/invocation_computer_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/keyword_computer_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/local_computer_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

Committed patchset #2 (id:20001) manually as 41865 (presubmit successful).

6 years, 1 month ago (2014-11-20 19:31:47 UTC) #4

scheglov

6 years, 1 month ago (2014-11-20 20:06:22 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/742163002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/driver.dart (left):

https://codereview.chromium.org/742163002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/driver.dart:7: import 'dart:async';
BTW, this breaks the server.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages