pkg/analysis_server/test/services/completion/completion_computer_test.dart - Issue 742163002: cache import suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_computer_test.dart

Issue 742163002: cache import suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/driver.dart ('K') | « pkg/analysis_server/test/services/completion/combinator_computer_test.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_computer_test.dart b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

index b230d494d2fa440ec4eb879a751121a83e16f2e5..3500955349d625fe23c71d81acab7bc1acfe9967 100644

--- a/pkg/analysis_server/test/services/completion/completion_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

@@ -44,6 +44,7 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {

Index index;

SearchEngineImpl searchEngine;

Source source;

+ CompletionCache cache;

CompletionPerformance perf;

DartCompletionManager manager;

MockCompletionComputer computer1;

@@ -63,8 +64,15 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {

index = createLocalMemoryIndex();

searchEngine = new SearchEngineImpl(index);

source = addSource('/does/not/exist.dart', '');

+ cache = null;

perf = new CompletionPerformance();

- manager = new DartCompletionManager(context, searchEngine, source, 0, perf);

+ manager = new DartCompletionManager.create(

+ context,

+ searchEngine,

+ source,

+ 0,

+ cache,

+ perf);

suggestion1 = new CompletionSuggestion(

CompletionSuggestionKind.INVOCATION,

CompletionRelevance.DEFAULT,