pkg/analysis_server/lib/src/services/completion/completion_manager.dart - Issue 742163002: cache import suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 742163002: cache import suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/driver.dart ('K') | « pkg/analysis_server/lib/driver.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart

index 8f1231cbed7f943c705cb8a623b04fadc99e846d..10b1486de8bdcdfda2e46e90f88aecb7272e03cb 100644

--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart

@@ -51,11 +51,12 @@ abstract class CompletionManager {

CompletionPerformance performance) {

if (context != null) {

if (AnalysisEngine.isDartFileName(source.shortName)) {

- return new DartCompletionManager(

+ return new DartCompletionManager.create(

context,

searchEngine,

source,

offset,

+ cache,

performance);

}

if (AnalysisEngine.isHtmlFileName(source.shortName)) {