cleanup hints

cleanup hints

BUG=
R=brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41852

[danrubel, 2014-11-19 01:36:06]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

[scheglov, 2014-11-19 02:12:39]

LGTM

[Paul Berry, 2014-11-19 02:20:36]

lgtm

[Brian Wilkerson, 2014-11-19 16:08:53]

LGTM

https://codereview.chromium.org/734403004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/734403004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:2922: // 
AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,
I don't know how our sorter deals with comments, but I know the JDT sorter will
keep commented out lines together if they are all the same kind of comment, so I
have to use end-of-line comments to comment out block comments if I don't want
them to get split up. I don't know whether that's necessary here or not.

[scheglov, 2014-11-19 17:30:20]

https://codereview.chromium.org/734403004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/734403004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:2922: // 
AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,
On 2014/11/19 16:08:52, Brian Wilkerson wrote:
> I don't know how our sorter deals with comments, but I know the JDT sorter
will
> keep commented out lines together if they are all the same kind of comment, so
I
> have to use end-of-line comments to comment out block comments if I don't want
> them to get split up. I don't know whether that's necessary here or not.

The sorter ignores comments, it reorders complete unit and class members.
If dartdoc is associated with a member, it will be moved with it.
As I understand, these comments are not associated with any comment.

But, I agree that it would be better to comment dartdocs too, just because they
are part of members, kind of external, but still a part.

[danrubel, 2014-11-20 14:01:25]

On 2014/11/19 17:30:20, scheglov wrote:
>
https://codereview.chromium.org/734403004/diff/1/pkg/analyzer/lib/src/generat...
> File pkg/analyzer/lib/src/generated/engine.dart (right):
> 
>
https://codereview.chromium.org/734403004/diff/1/pkg/analyzer/lib/src/generat...
> pkg/analyzer/lib/src/generated/engine.dart:2922: // 
> AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,
> On 2014/11/19 16:08:52, Brian Wilkerson wrote:
> > I don't know how our sorter deals with comments, but I know the JDT sorter
> will
> > keep commented out lines together if they are all the same kind of comment,
so
> I
> > have to use end-of-line comments to comment out block comments if I don't
want
> > them to get split up. I don't know whether that's necessary here or not.
> 
> The sorter ignores comments, it reorders complete unit and class members.
> If dartdoc is associated with a member, it will be moved with it.
> As I understand, these comments are not associated with any comment.
> 
> But, I agree that it would be better to comment dartdocs too, just because
they
> are part of members, kind of external, but still a part.

Good point. Done.

[danrubel, 2014-11-20 14:03:27]

Committed patchset #1 (id:1) manually as 41852 (presubmit successful).