cleanup hints

pkg/analyzer/lib/src/generated/engine.dart

Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index f8847760ef8f1d18245f01f4e2c93d28cbb474c9..e374b7a38c4537ccad042131da83c4f9db7c00b8 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -2919,16 +2919,16 @@ class AnalysisContextImpl implements InternalAnalysisContext {
   /**
    * Create a [BuildUnitElementTask] for the given [source].
    */
-  AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,
-      DartEntry dartEntry, Source librarySource) {
-    CompilationUnit unit = dartEntry.resolvableCompilationUnit;
-    if (unit == null) {
-      return _createParseDartTask(source, dartEntry);
-    }
-    return new AnalysisContextImpl_TaskData(
-        new BuildUnitElementTask(this, source, librarySource, unit),
-        false);
-  }
+//  AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,

[Brian Wilkerson, 2014/11/19 16:08:52]

I don't know how our sorter deals with comments, but I know the JDT sorter will
keep commented out lines together if they are all the same kind of comment, so I
have to use end-of-line comments to comment out block comments if I don't want
them to get split up. I don't know whether that's necessary here or not.

[scheglov, 2014/11/19 17:30:19]

The sorter ignores comments, it reorders complete unit and class members.
If dartdoc is associated with a member, it will be moved with it.
As I understand, these comments are not associated with any comment.

But, I agree that it would be better to comment dartdocs too, just because they
are part of members, kind of external, but still a part.

+//      DartEntry dartEntry, Source librarySource) {
+//    CompilationUnit unit = dartEntry.resolvableCompilationUnit;
+//    if (unit == null) {
+//      return _createParseDartTask(source, dartEntry);
+//    }
+//    return new AnalysisContextImpl_TaskData(
+//        new BuildUnitElementTask(this, source, librarySource, unit),
+//        false);
+//  }
 
   /**
    * Create a [GenerateDartErrorsTask] for the given source, marking the verification errors
@@ -4219,12 +4219,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
    *
    * @param source the source that is no longer being analyzed
    */
-  void _notifyExcludedSource(Source source) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].excludedSource(this, source);
-    }
-  }
+//  void _notifyExcludedSource(Source source) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].excludedSource(this, source);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given source is now included in the set of
@@ -4232,12 +4232,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
    *
    * @param source the source that is now being analyzed
    */
-  void _notifyIncludedSource(Source source) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].includedSource(this, source);
-    }
-  }
+//  void _notifyIncludedSource(Source source) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].includedSource(this, source);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given Dart source was parsed.
@@ -4245,12 +4245,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
    * @param source the source that was parsed
    * @param unit the result of parsing the source
    */
-  void _notifyParsedDart(Source source, CompilationUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].parsedDart(this, source, unit);
-    }
-  }
+//  void _notifyParsedDart(Source source, CompilationUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].parsedDart(this, source, unit);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given HTML source was parsed.
@@ -4258,12 +4258,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
    * @param source the source that was parsed
    * @param unit the result of parsing the source
    */
-  void _notifyParsedHtml(Source source, ht.HtmlUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].parsedHtml(this, source, unit);
-    }
-  }
+//  void _notifyParsedHtml(Source source, ht.HtmlUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].parsedHtml(this, source, unit);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given Dart source was resolved.
@@ -4271,12 +4271,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
    * @param source the source that was resolved
    * @param unit the result of resolving the source
    */
-  void _notifyResolvedDart(Source source, CompilationUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].resolvedDart(this, source, unit);
-    }
-  }
+//  void _notifyResolvedDart(Source source, CompilationUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].resolvedDart(this, source, unit);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given HTML source was resolved.
@@ -4284,12 +4284,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {
    * @param source the source that was resolved
    * @param unit the result of resolving the source
    */
-  void _notifyResolvedHtml(Source source, ht.HtmlUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].resolvedHtml(this, source, unit);
-    }
-  }
+//  void _notifyResolvedHtml(Source source, ht.HtmlUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].resolvedHtml(this, source, unit);
+//    }
+//  }
 
   /**
    * Updates [HtmlEntry]s that correspond to the previously known and new Angular application
@@ -6828,7 +6828,7 @@ class AngularHtmlUnitResolver extends ht.RecursiveXmlVisitor<Object> {
 
   final ht.HtmlUnit _unit;
 
-  List<AngularElement> _angularElements;
+//  List<AngularElement> _angularElements;
 
   List<NgProcessor> _processors = <NgProcessor>[];
 
@@ -7143,14 +7143,14 @@ class AngularHtmlUnitResolver extends ht.RecursiveXmlVisitor<Object> {
   /**
    * @return the [AngularElement] with the given name, maybe `null`.
    */
-  AngularElement _findAngularElement(String name) {
-    for (AngularElement element in _angularElements) {
-      if (name == element.name) {
-        return element;
-      }
-    }
-    return null;
-  }
+//  AngularElement _findAngularElement(String name) {
+//    for (AngularElement element in _angularElements) {
+//      if (name == element.name) {
+//        return element;
+//      }
+//    }
+//    return null;
+//  }
 
   /**
    * Parses given [String] as an [AngularExpression] at the given offset.
@@ -7204,11 +7204,11 @@ class AngularHtmlUnitResolver extends ht.RecursiveXmlVisitor<Object> {
   /**
    * Parses given [String] as an [Expression] at the given offset.
    */
-  Expression _parseDartExpression(String contents, int startIndex, int endIndex,
-      int offset) {
-    Token token = _scanDart(contents, startIndex, endIndex, offset);
-    return _parseDartExpressionInToken(token);
-  }
+//  Expression _parseDartExpression(String contents, int startIndex, int endIndex,
+//      int offset) {
+//    Token token = _scanDart(contents, startIndex, endIndex, offset);
+//    return _parseDartExpressionInToken(token);
+//  }
 
   Expression _parseDartExpressionInToken(Token token) {
     Parser parser = new Parser(_source, _errorListener);
@@ -7369,7 +7369,7 @@ class AngularHtmlUnitResolver extends ht.RecursiveXmlVisitor<Object> {
    */
   void _resolveInternal(List<AngularElement> angularElements,
       AngularComponentElement component) {
-    this._angularElements = angularElements;
+//    this._angularElements = angularElements;
     // add built-in processors
     _processors.add(NgModelProcessor.INSTANCE);
     // _processors.add(NgRepeatProcessor.INSTANCE);