cleanup hints

pkg/analyzer/lib/src/generated/engine.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine;
 
 import "dart:math" as math;
@@ skipping 2901 matching lines @@
       _incrementalAnalysisCache = IncrementalAnalysisCache.clear(_incrementalAnalysisCache, source);
       _sourceChanged(source);
       changed = true;
     }
     return changed;
   }
 
   /**
    * Create a [BuildUnitElementTask] for the given [source].
    */
-  AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,
-      DartEntry dartEntry, Source librarySource) {
-    CompilationUnit unit = dartEntry.resolvableCompilationUnit;
-    if (unit == null) {
-      return _createParseDartTask(source, dartEntry);
-    }
-    return new AnalysisContextImpl_TaskData(
-        new BuildUnitElementTask(this, source, librarySource, unit),
-        false);
-  }
+//  AnalysisContextImpl_TaskData _createBuildUnitElementTask(Source source,

[Brian Wilkerson, 2014/11/19 16:08:52]

I don't know how our sorter deals with comments, but I know the JDT sorter will
keep commented out lines together if they are all the same kind of comment, so I
have to use end-of-line comments to comment out block comments if I don't want
them to get split up. I don't know whether that's necessary here or not.

[scheglov, 2014/11/19 17:30:19]

The sorter ignores comments, it reorders complete unit and class members.
If dartdoc is associated with a member, it will be moved with it.
As I understand, these comments are not associated with any comment.

But, I agree that it would be better to comment dartdocs too, just because they
are part of members, kind of external, but still a part.

+//      DartEntry dartEntry, Source librarySource) {
+//    CompilationUnit unit = dartEntry.resolvableCompilationUnit;
+//    if (unit == null) {
+//      return _createParseDartTask(source, dartEntry);
+//    }
+//    return new AnalysisContextImpl_TaskData(
+//        new BuildUnitElementTask(this, source, librarySource, unit),
+//        false);
+//  }
 
   /**
    * Create a [GenerateDartErrorsTask] for the given source, marking the verification errors
    * as being in-process. The compilation unit and the library can be the same if the compilation
    * unit is the defining compilation unit of the library.
    *
    * @param unitSource the source for the compilation unit to be verified
    * @param unitEntry the entry for the compilation unit
    * @param librarySource the source for the library containing the compilation unit
    * @param libraryEntry the entry for the library
@@ skipping 1270 matching lines @@
       _listeners[i].computedErrors(this, source, errors, lineInfo);
     }
   }
 
   /**
    * Notify all of the analysis listeners that the given source is no longer included in the set of
    * sources that are being analyzed.
    *
    * @param source the source that is no longer being analyzed
    */
-  void _notifyExcludedSource(Source source) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].excludedSource(this, source);
-    }
-  }
+//  void _notifyExcludedSource(Source source) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].excludedSource(this, source);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given source is now included in the set of
    * sources that are being analyzed.
    *
    * @param source the source that is now being analyzed
    */
-  void _notifyIncludedSource(Source source) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].includedSource(this, source);
-    }
-  }
+//  void _notifyIncludedSource(Source source) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].includedSource(this, source);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given Dart source was parsed.
    *
    * @param source the source that was parsed
    * @param unit the result of parsing the source
    */
-  void _notifyParsedDart(Source source, CompilationUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].parsedDart(this, source, unit);
-    }
-  }
+//  void _notifyParsedDart(Source source, CompilationUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].parsedDart(this, source, unit);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given HTML source was parsed.
    *
    * @param source the source that was parsed
    * @param unit the result of parsing the source
    */
-  void _notifyParsedHtml(Source source, ht.HtmlUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].parsedHtml(this, source, unit);
-    }
-  }
+//  void _notifyParsedHtml(Source source, ht.HtmlUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].parsedHtml(this, source, unit);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given Dart source was resolved.
    *
    * @param source the source that was resolved
    * @param unit the result of resolving the source
    */
-  void _notifyResolvedDart(Source source, CompilationUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].resolvedDart(this, source, unit);
-    }
-  }
+//  void _notifyResolvedDart(Source source, CompilationUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].resolvedDart(this, source, unit);
+//    }
+//  }
 
   /**
    * Notify all of the analysis listeners that the given HTML source was resolved.
    *
    * @param source the source that was resolved
    * @param unit the result of resolving the source
    */
-  void _notifyResolvedHtml(Source source, ht.HtmlUnit unit) {
-    int count = _listeners.length;
-    for (int i = 0; i < count; i++) {
-      _listeners[i].resolvedHtml(this, source, unit);
-    }
-  }
+//  void _notifyResolvedHtml(Source source, ht.HtmlUnit unit) {
+//    int count = _listeners.length;
+//    for (int i = 0; i < count; i++) {
+//      _listeners[i].resolvedHtml(this, source, unit);
+//    }
+//  }
 
   /**
    * Updates [HtmlEntry]s that correspond to the previously known and new Angular application
    * information.
    */
   void _recordAngularEntryPoint(HtmlEntry entry,
       ResolveAngularEntryHtmlTask task) {
     AngularApplication application = task.application;
     if (application != null) {
       _angularApplications.add(application);
@@ skipping 2518 matching lines @@
   TypeProvider _typeProvider;
 
   AngularHtmlUnitResolver_FilteringAnalysisErrorListener _errorListener;
 
   final Source _source;
 
   final LineInfo _lineInfo;
 
   final ht.HtmlUnit _unit;
 
-  List<AngularElement> _angularElements;
+//  List<AngularElement> _angularElements;
 
   List<NgProcessor> _processors = <NgProcessor>[];
 
   LibraryElementImpl _libraryElement;
 
   CompilationUnitElementImpl _unitElement;
 
   FunctionElementImpl _functionElement;
 
   ResolverVisitor _resolver;
@@ skipping 294 matching lines @@
    */
   void _defineVariable(LocalVariableElementImpl variable) {
     _recordDefinedVariable(variable);
     _nameScope.define(variable);
     _recordTypeLibraryInjected(variable);
   }
 
   /**
    * @return the [AngularElement] with the given name, maybe `null`.
    */
-  AngularElement _findAngularElement(String name) {
-    for (AngularElement element in _angularElements) {
-      if (name == element.name) {
-        return element;
-      }
-    }
-    return null;
-  }
+//  AngularElement _findAngularElement(String name) {
+//    for (AngularElement element in _angularElements) {
+//      if (name == element.name) {
+//        return element;
+//      }
+//    }
+//    return null;
+//  }
 
   /**
    * Parses given [String] as an [AngularExpression] at the given offset.
    */
   AngularExpression _parseAngularExpression(String contents, int startIndex,
       int endIndex, int offset) {
     Token token = _scanDart(contents, startIndex, endIndex, offset);
     return _parseAngularExpressionInToken(token);
   }
 
@@ skipping 33 matching lines @@
       }
       formatters.add(new AngularFormatterNode(barToken, name, arguments));
     }
     // done
     return new AngularExpression(mainExpression, formatters);
   }
 
   /**
    * Parses given [String] as an [Expression] at the given offset.
    */
-  Expression _parseDartExpression(String contents, int startIndex, int endIndex,
-      int offset) {
-    Token token = _scanDart(contents, startIndex, endIndex, offset);
-    return _parseDartExpressionInToken(token);
-  }
+//  Expression _parseDartExpression(String contents, int startIndex, int endIndex,
+//      int offset) {
+//    Token token = _scanDart(contents, startIndex, endIndex, offset);
+//    return _parseDartExpressionInToken(token);
+//  }
 
   Expression _parseDartExpressionInToken(Token token) {
     Parser parser = new Parser(_source, _errorListener);
     return parser.parseExpression(token);
   }
 
   /**
    * Parse the value of the given token for embedded expressions, and add any embedded expressions
    * that are found to the given list of expressions.
    *
@@ skipping 140 matching lines @@
   /**
    * Resolves Angular specific expressions and elements in the [source].
    *
    * @param angularElements the [AngularElement]s accessible in the component's library, not
    *          `null`
    * @param component the [AngularComponentElement] to resolve template for, maybe
    *          `null` if not a component template
    */
   void _resolveInternal(List<AngularElement> angularElements,
       AngularComponentElement component) {
-    this._angularElements = angularElements;
+//    this._angularElements = angularElements;
     // add built-in processors
     _processors.add(NgModelProcessor.INSTANCE);
     // _processors.add(NgRepeatProcessor.INSTANCE);
     // add element's libraries
     for (AngularElement angularElement in angularElements) {
       _injectedLibraries.add(angularElement.library);
     }
     // prepare Dart library
     _createLibraryElement();
     (_unit.element as HtmlElementImpl).angularCompilationUnit = _unitElement;
@@ skipping 7422 matching lines @@
 
   @override
   Object visitPolymerTagDartElement(PolymerTagDartElement element) {
     if (element.name == PolymerHtmlUnitBuilder_this._elementName) {
       throw new PolymerHtmlUnitBuilder_FoundTagDartElementError(
           element as PolymerTagDartElementImpl);
     }
     return null;
   }
 }