Issue 727623002: Support verified heap pointer writes on x64.

Issue 727623002: Support verified heap pointer writes on x64. (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support verified heap pointer writes on x64. Port of r41607, r41700, and upcoming change: https://codereview.chromium.org/721233002/ R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41787

Patch Set 3 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -43 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1 2	3 chunks	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2	5 chunks	+86 lines, -2 lines	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	1 2	3 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	2 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2	5 chunks	+7 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2	13 chunks	+36 lines, -20 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -Ivan https://codereview.chromium.org/727623002/diff/20001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/727623002/diff/20001/runtime/vm/assembler_x64.cc#newcode2880 runtime/vm/assembler_x64.cc:2880: void Assembler::Verify(const Address& dest) { ditto about ...

6 years, 1 month ago (2014-11-14 22:16:07 UTC) #2

koda

https://codereview.chromium.org/727623002/diff/20001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/727623002/diff/20001/runtime/vm/assembler_x64.cc#newcode2880 runtime/vm/assembler_x64.cc:2880: void Assembler::Verify(const Address& dest) { On 2014/11/14 22:16:06, Ivan ...

6 years, 1 month ago (2014-11-17 17:09:00 UTC) #3

koda

6 years, 1 month ago (2014-11-17 18:09:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r41787 (presubmit successful).

Expand Messages | Collapse Messages