Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Unified Diff: runtime/vm/assembler_x64.h

Issue 727623002: Support verified heap pointer writes on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.h
===================================================================
--- runtime/vm/assembler_x64.h (revision 41785)
+++ runtime/vm/assembler_x64.h (working copy)
@@ -650,10 +650,12 @@
void int3();
void hlt();
+ // Note: verified_mem mode forces far jumps.
void j(Condition condition, Label* label, bool near = kFarJump);
void j(Condition condition, const ExternalLabel* label);
void jmp(Register reg);
+ // Note: verified_mem mode forces far jumps.
void jmp(Label* label, bool near = kFarJump);
void jmp(const ExternalLabel* label);
@@ -748,6 +750,12 @@
const Address& dest,
Register value);
+ // Stores a Smi value into a heap object field that always contains a Smi.
+ void StoreIntoSmiField(const Address& dest, Register value);
+ void ZeroSmiField(const Address& dest);
+ // Increments a Smi field. Leaves flags in same state as an 'addq'.
+ void IncrementSmiField(const Address& dest, int64_t increment);
+
void DoubleNegate(XmmRegister d);
void FloatNegate(XmmRegister f);
@@ -1076,6 +1084,11 @@
Register value,
Label* no_update);
+ // Analogous to VerifiedMemory::Verify(address, kWordSize).
+ void VerifyHeapWord(const Address& address);
+ // Analogous to VerifiedMemory::Write.
+ void VerifiedWrite(const Address& dest, Register value);
+
void ComputeCounterAddressesForCid(intptr_t cid,
Heap::Space space,
Address* count_address,
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698