Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: runtime/vm/code_patcher_x64.cc

Issue 727623002: Support verified heap pointer writes on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_x64.cc
===================================================================
--- runtime/vm/code_patcher_x64.cc (revision 41785)
+++ runtime/vm/code_patcher_x64.cc (working copy)
@@ -9,6 +9,7 @@
#include "vm/code_patcher.h"
#include "vm/cpu.h"
#include "vm/dart_entry.h"
+#include "vm/flow_graph_compiler.h"
#include "vm/instructions.h"
#include "vm/object.h"
#include "vm/raw_object.h"
@@ -303,7 +304,8 @@
class EdgeCounter : public ValueObject {
public:
EdgeCounter(uword pc, const Code& code)
- : end_(pc - kAdjust), object_pool_(Array::Handle(code.ObjectPool())) {
+ : end_(pc - FlowGraphCompiler::EdgeCounterIncrementSizeInBytes()),
+ object_pool_(Array::Handle(code.ObjectPool())) {
ASSERT(IsValid(end_));
}
@@ -317,11 +319,6 @@
}
private:
- // The edge counter load is followed by the fixed-size edge counter
- // incrementing code:
- // 48 83 40 17 02 addq [rax+0x17],0x2
- static const intptr_t kAdjust = 5;
-
uword end_;
const Array& object_pool_;
};
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698