Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 723263004: make completion managers responsible for their own caches (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

make completion managers responsible for their own caches - move cache out of CompletionDomainHandler into CompletionManager - make CompletionManager longer lived - move context and source fields out of DartCompletionManager and into superclass - encapsulate information related to a specific request in new CompletionRequest rather than in the manager - remove request specific information from CompletionManager creation - use same ContextManager instance for consecutive requests on the same context/source pair BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42157

Patch Set 1 #

Patch Set 2 : merge #

Messages

Total messages: 4 (1 generated)
danrubel
6 years ago (2014-12-06 19:32:39 UTC) #2
scheglov
LGTM
6 years ago (2014-12-07 02:12:31 UTC) #3
danrubel
6 years ago (2014-12-07 19:32:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698