make completion managers responsible for their own caches

pkg/analysis_server/lib/src/services/completion/completion_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 19 matching lines @@
 
   CompletionCache(this.context, this.source);
 }
 
 /**
  * Manages `CompletionComputer`s for a given completion request.
  */
 abstract class CompletionManager {
 
   /**
+   * The context in which the completion was computed.
+   */
+  final AnalysisContext context;
+
+  /**
+   * The source in which the completion was computed.
+   */
+  final Source source;
+
+  /**
    * The controller used for returning completion results.
    */
   StreamController<CompletionResult> controller;
 
-  CompletionManager();
+  CompletionManager(this.context, this.source);
 
   /**
    * Create a manager for the given request.
    */
   factory CompletionManager.create(AnalysisContext context, Source source,
-      int offset, SearchEngine searchEngine, CompletionCache cache,
-      CompletionPerformance performance) {
+      SearchEngine searchEngine, CompletionCache cache) {
     if (context != null) {
       if (AnalysisEngine.isDartFileName(source.shortName)) {
         return new DartCompletionManager.create(
             context,
             searchEngine,
             source,
-            offset,
-            cache,
-            performance);
+            cache);
       }
       if (AnalysisEngine.isHtmlFileName(source.shortName)) {
         //TODO (danrubel) implement
 //        return new HtmlCompletionManager(context, searchEngine, source, offset);
       }
     }
-    return new NoOpCompletionManager(source, offset);
+    return new NoOpCompletionManager(source);
   }
 
   /**
-   * Return cached information from the current completion operation
-   * if there is any. Subclasses may override this method.
-   */
-  CompletionCache get completionCache => null;
-
-  /**
-   * Compute completion results and append them to the stream.
+   * Compute completion results for the given reqeust and append them to the stream.
    * Clients should not call this method directly as it is automatically called
    * when a client listens to the stream returned by [results].
    * Subclasses should override this method, append at least one result
    * to the [controller], and close the controller stream once complete.
    */
-  void compute();
+  void compute(CompletionRequest request);
 
   /**
    * Generate a stream of code completion results.
    */
-  Stream<CompletionResult> results() {
+  Stream<CompletionResult> results(CompletionRequest request) {
     controller = new StreamController<CompletionResult>(onListen: () {
-      scheduleMicrotask(compute);
+      scheduleMicrotask(() {
+        compute(request);
+      });
     });
     return controller.stream;
   }
 }
 
 /**
  * Overall performance of a code completion operation.
  */
 class CompletionPerformance {
   final Map<String, Duration> _startTimes = new Map<String, Duration>();
@@ skipping 31 matching lines @@
   void logStartTime(String tag) {
     _startTimes[tag] = _stopwatch.elapsed;
   }
 
   void _logDuration(String tag, Duration elapsed) {
     operations.add(new OperationPerformance(tag, elapsed));
   }
 }
 
 /**
+ * Encapsulates information specific to a particular completion request.
+ */
+class CompletionRequest {
+  /**
+   * The offset within the source at which the completion is requested.
+   */
+  final int offset;
+
+  /**
+   * Performance measurements for this particular request.
+   */
+  final CompletionPerformance performance;
+
+  CompletionRequest(this.offset, this.performance);
+}
+
+/**
  * Code completion result generated by an [CompletionManager].
  */
 class CompletionResult {
 
   /**
    * The length of the text to be replaced if the remainder of the identifier
    * containing the cursor is to be replaced when the suggestion is applied
    * (that is, the number of characters in the existing identifier).
    */
   final int replacementLength;
@@ skipping 15 matching lines @@
    * `true` if this is that last set of results that will be returned
    * for the indicated completion.
    */
   final bool last;
 
   CompletionResult(this.replacementOffset, this.replacementLength,
       this.suggestions, this.last);
 }
 
 class NoOpCompletionManager extends CompletionManager {
-  final Source source;
-  final int offset;
 
-  NoOpCompletionManager(this.source, this.offset);
+  NoOpCompletionManager(Source source) : super(null, source);
 
   @override
-  void compute() {
-    controller.add(new CompletionResult(offset, 0, [], true));
+  void compute(CompletionRequest request) {
+    controller.add(new CompletionResult(request.offset, 0, [], true));
   }
 }
 
 /**
  * The performance of an operation when computing code completion.
  */
 class OperationPerformance {
 
   /**
    * The name of the operation
    */
   final String name;
 
   /**
    * The elapse time or `null` if undefined.
    */
   final Duration elapsed;
 
   OperationPerformance(this.name, this.elapsed);
 }