Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: pkg/analysis_server/test/services/completion/completion_computer_test.dart

Issue 723263004: make completion managers responsible for their own caches (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_computer_test.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_computer_test.dart b/pkg/analysis_server/test/services/completion/completion_computer_test.dart
index 3500955349d625fe23c71d81acab7bc1acfe9967..fb2a167897a9c68a1956b53b0f81ec2f4acdc0c3 100644
--- a/pkg/analysis_server/test/services/completion/completion_computer_test.dart
+++ b/pkg/analysis_server/test/services/completion/completion_computer_test.dart
@@ -66,13 +66,8 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {
source = addSource('/does/not/exist.dart', '');
cache = null;
perf = new CompletionPerformance();
- manager = new DartCompletionManager.create(
- context,
- searchEngine,
- source,
- 0,
- cache,
- perf);
+ manager =
+ new DartCompletionManager.create(context, searchEngine, source, cache);
suggestion1 = new CompletionSuggestion(
CompletionSuggestionKind.INVOCATION,
CompletionRelevance.DEFAULT,
@@ -97,7 +92,8 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {
manager.computers = [computer1, computer2];
int count = 0;
bool done = false;
- manager.results().listen((CompletionResult r) {
+ CompletionRequest completionRequest = new CompletionRequest(0, perf);
+ manager.results(completionRequest).listen((CompletionResult r) {
switch (++count) {
case 1:
computer1.assertCalls(context, source, 0, searchEngine);
@@ -133,7 +129,8 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {
manager.computers = [computer1, computer2];
int count = 0;
bool done = false;
- manager.results().listen((CompletionResult r) {
+ CompletionRequest completionRequest = new CompletionRequest(0, perf);
+ manager.results(completionRequest).listen((CompletionResult r) {
switch (++count) {
case 1:
computer1.assertCalls(context, source, 0, searchEngine);

Powered by Google App Engine
This is Rietveld 408576698