Issue 713993002: Fix unsigned multiplication in MIPS simulator (add assembler regression test).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 713993002: Fix unsigned multiplication in MIPS simulator (add assembler regression test). (Closed)

Created:
6 years, 1 month ago by regis

Modified:
6 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix unsigned multiplication in MIPS simulator (add assembler regression test). Fix breakpoint handling in MIPS simulator. Fix potential overflow in Bigint_sqrAdd intrinsic on ARM. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=41674

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -24 lines)			Patch
M	runtime/vm/assembler_mips_test.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1	1 chunk	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	2 chunks	+13 lines, -11 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1	5 chunks	+18 lines, -6 lines	0 comments	Download

Total messages: 5 (1 generated)

regis

6 years, 1 month ago (2014-11-11 22:29:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r41674 (presubmit successful).