runtime/vm/assembler_mips_test.cc - Issue 713993002: Fix unsigned multiplication in MIPS simulator (add assembler regression test).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_mips_test.cc

Issue 713993002: Fix unsigned multiplication in MIPS simulator (add assembler regression test). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_mips_test.cc

===================================================================

--- runtime/vm/assembler_mips_test.cc (revision 41673)

+++ runtime/vm/assembler_mips_test.cc (working copy)

@@ -505,8 +505,8 @@

ASSEMBLER_TEST_GENERATE(Multu_hi, assembler) {

- __ LoadImmediate(T1, 65536);

- __ LoadImmediate(T2, 65536);

+ __ LoadImmediate(T1, -1);

+ __ LoadImmediate(T2, -1);

__ multu(T1, T2);

__ mfhi(V0);

__ jr(RA);

@@ -515,7 +515,7 @@

ASSEMBLER_TEST_RUN(Multu_hi, test) {

typedef int (*SimpleCode)() DART_UNUSED;

- EXPECT_EQ(1, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));

+ EXPECT_EQ(0xfffffffe, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));

}

« no previous file with comments | « no previous file | runtime/vm/constants_mips.h » ('j') | no next file with comments »