runtime/vm/constants_mips.h - Issue 713993002: Fix unsigned multiplication in MIPS simulator (add assembler regression test).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_mips.h

Issue 713993002: Fix unsigned multiplication in MIPS simulator (add assembler regression test). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/constants_mips.h

===================================================================

--- runtime/vm/constants_mips.h (revision 41673)

+++ runtime/vm/constants_mips.h (working copy)

@@ -456,12 +456,18 @@

kInstrSize = 4,

};

+ static const int32_t kNopInstruction = 0;

+ // Reserved break instruction codes.

+ static const int32_t kStopMessageCode = 1 << 16; // For Stop(message).

+ static const int32_t kRedirectCode = 2 << 16; // For call redirection in sim.

+ static const int32_t kMsgMessageCode = 3 << 16; // For trace message in sim.

+ static const int32_t kSimulatorBreakCode = 4 << 16; // For breakpoint in sim.

+ // General breakpoint instruction: break(0), for user breakpoint and to fill

+ // assembler code buffers in debug mode.

static const int32_t kBreakPointInstruction =

(SPECIAL << kOpcodeShift) | (BREAK << kFunctionShift);

- static const int32_t kNopInstruction = 0;

- static const int32_t kStopMessageCode = 1;

- static const int32_t kRedirectCode = 2;

- static const int32_t kMsgMessageCode = 3;

// Get the raw instruction bits.

inline int32_t InstructionBits() const {

« no previous file with comments | « runtime/vm/assembler_mips_test.cc ('k') | runtime/vm/intrinsifier_arm.cc » ('j') | no next file with comments »