Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 702673002: Improve handling of intentionally broken links in test scripts. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Improve handling of intentionally broken links in test scripts. BUG= Committed: https://code.google.com/p/dart/source/detail?r=41492

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M tests/_chrome/sample_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/audioelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/http_server.dart View 2 chunks +3 lines, -13 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
6 years, 1 month ago (2014-11-04 14:24:24 UTC) #2
ricow1
https://codereview.chromium.org/702673002/diff/1/tools/testing/dart/http_server.dart File tools/testing/dart/http_server.dart (right): https://codereview.chromium.org/702673002/diff/1/tools/testing/dart/http_server.dart#newcode129 tools/testing/dart/http_server.dart:129: "IntentionallyMissingFile", don't you need a slash in front?
6 years, 1 month ago (2014-11-04 14:26:59 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 41492 (presubmit successful).
6 years, 1 month ago (2014-11-04 15:00:15 UTC) #4
Bill Hesse
6 years, 1 month ago (2014-11-04 15:23:22 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/702673002/diff/1/tools/testing/dart/http_serv...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/702673002/diff/1/tools/testing/dart/http_serv...
tools/testing/dart/http_server.dart:129: "IntentionallyMissingFile",
On 2014/11/04 14:26:59, ricow1 wrote:
> don't you need a slash in front?

No, the co19 people have been creating new tests using names like
"old_IntentionallyMissingFile" and "new_IntentionallyMissingFile", as well as
files named "IntentionallyMissingFile01" through "IntentionallyMissingFile40". 
I thought of telling them to stop it, but there is really no reason for us not
to allow that flexibility.

Powered by Google App Engine
This is Rietveld 408576698