Improve handling of intentionally broken links in test scripts.

tools/testing/dart/http_server.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library http_server;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'dart:convert' show
@@ skipping 108 matching lines @@
  */
 class TestingServers {
   static final _CACHE_EXPIRATION_IN_SECONDS = 30;
   static final _HARMLESS_REQUEST_PATH_ENDINGS = [
     "/apple-touch-icon.png",
     "/apple-touch-icon-precomposed.png",
     "/favicon.ico",
     "/foo",
     "/bar",
     "/NonExistingFile",
-    "/NonExistingFile.js",
-    "/hahaURL",
-    "/IntentionallyMissingFile",
-    "/IntentionallyMissingFile.dart",
-    "/IntentionallyMissingFile.html",
-    "/IntentionallyMissingFile.png",
-    "/IntentionallyMissingFile.css",
-    "/IntentionallyMissingFile.jpg",
-    "/IntentionallyMissingFile.ttf",
-    "/IntentionallyMissingFile.otf",
-    "/IntentionallyMissingFile.jpeg"
+    "IntentionallyMissingFile",

[ricow1, 2014/11/04 14:26:59]

don't you need a slash in front?

[Bill Hesse, 2014/11/04 15:23:22]

No, the co19 people have been creating new tests using names like
"old_IntentionallyMissingFile" and "new_IntentionallyMissingFile", as well as
files named "IntentionallyMissingFile01" through "IntentionallyMissingFile40". 
I thought of telling them to stop it, but there is really no reason for us not
to allow that flexibility.

   ];
 
   List _serverList = [];
   Path _buildDirectory = null;
   Path _dartDirectory = null;
   Path _packageRoot;
   final bool useContentSecurityPolicy;
   final String runtime;
   DispatchingServer _server;
 
@@ skipping 262 matching lines @@
     }
     response.headers.removeAll("X-Frame-Options");
     file.openRead().pipe(response).catchError((e) {
       DebugLogger.warning(
           'HttpServer: error while closing the response stream', e);
     });
   }
 
   void _sendNotFound(HttpRequest request) {
     bool isHarmlessPath(String path) {
-      return _HARMLESS_REQUEST_PATH_ENDINGS.any((ending) {
-        return path.endsWith(ending);
+      return _HARMLESS_REQUEST_PATH_ENDINGS.any((pattern) {
+        return path.contains(pattern);
       });
     }
     if (!isHarmlessPath(request.uri.path)) {
       DebugLogger.warning('HttpServer: could not find file for request path: '
                           '"${request.uri.path}"');
     }
     var response = request.response;
     response.statusCode = HttpStatus.NOT_FOUND;
 
     // Send a nice HTML page detailing the error message.  Most browsers expect
@@ skipping 27 matching lines @@
 class _Entry implements Comparable {
   final String name;
   final String displayName;
 
   _Entry(this.name, this.displayName);
 
   int compareTo(_Entry other) {
     return name.compareTo(other.name);
   }
 }