Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/testing/dart/http_server.dart

Issue 702673002: Improve handling of intentionally broken links in test scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/audioelement_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/http_server.dart
diff --git a/tools/testing/dart/http_server.dart b/tools/testing/dart/http_server.dart
index 14cb0ff8dbe43f9d8ed6aff9a94b7d6b4c8fbd03..a5e7b8eba1559afa31e963d5b7d42292adbeb68c 100644
--- a/tools/testing/dart/http_server.dart
+++ b/tools/testing/dart/http_server.dart
@@ -126,17 +126,7 @@ class TestingServers {
"/foo",
"/bar",
"/NonExistingFile",
- "/NonExistingFile.js",
- "/hahaURL",
- "/IntentionallyMissingFile",
- "/IntentionallyMissingFile.dart",
- "/IntentionallyMissingFile.html",
- "/IntentionallyMissingFile.png",
- "/IntentionallyMissingFile.css",
- "/IntentionallyMissingFile.jpg",
- "/IntentionallyMissingFile.ttf",
- "/IntentionallyMissingFile.otf",
- "/IntentionallyMissingFile.jpeg"
+ "IntentionallyMissingFile",
ricow1 2014/11/04 14:26:59 don't you need a slash in front?
Bill Hesse 2014/11/04 15:23:22 No, the co19 people have been creating new tests u
];
List _serverList = [];
@@ -419,8 +409,8 @@ class TestingServers {
void _sendNotFound(HttpRequest request) {
bool isHarmlessPath(String path) {
- return _HARMLESS_REQUEST_PATH_ENDINGS.any((ending) {
- return path.endsWith(ending);
+ return _HARMLESS_REQUEST_PATH_ENDINGS.any((pattern) {
+ return path.contains(pattern);
});
}
if (!isHarmlessPath(request.uri.path)) {
« no previous file with comments | « tests/html/audioelement_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698