Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 658103003: Support map and list literals in analyzer2dart. (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org, Paul Berry
Visibility:
Public.

Description

Support map and list literals in analyzer2dart. BUG= R=paulberry@google.com, sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41391

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : Use LiteralMapEntry to ensure build order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -69 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 2 2 chunks +63 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 2 1 chunk +109 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 2 4 chunks +35 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 1 2 1 chunk +8 lines, -16 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart View 1 2 4 chunks +19 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/shrinking_reductions.dart View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart View 1 2 3 chunks +25 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/logical_rewriter.dart View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/statement_rewriter.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_builder.dart View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart View 1 2 2 chunks +13 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Johnni Winther
https://codereview.chromium.org/658103003/diff/1/pkg/analyzer2dart/test/end2end_test.dart File pkg/analyzer2dart/test/end2end_test.dart (left): https://codereview.chromium.org/658103003/diff/1/pkg/analyzer2dart/test/end2end_test.dart#oldcode206 pkg/analyzer2dart/test/end2end_test.dart:206: ''', ''' Removing redundant expected results.
6 years, 2 months ago (2014-10-21 10:27:05 UTC) #2
sigurdm
lgtm
6 years, 2 months ago (2014-10-21 11:04:07 UTC) #3
Paul Berry
lgtm
6 years, 2 months ago (2014-10-21 11:59:02 UTC) #5
Johnni Winther
PTAL @ the last patch I forgot to upload an intermediate rebase so the last ...
6 years, 1 month ago (2014-10-29 09:51:58 UTC) #7
sigurdm
lgtm
6 years, 1 month ago (2014-10-29 10:01:18 UTC) #8
Johnni Winther
Committed patchset #3 (id:60001) manually as 41391 (presubmit successful).
6 years, 1 month ago (2014-10-29 10:06:44 UTC) #9
Paul Berry
6 years, 1 month ago (2014-10-29 14:26:28 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698