sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart - Issue 658103003: Support map and list literals in analyzer2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart

Issue 658103003: Support map and list literals in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use LiteralMapEntry to ensure build order Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/elements/modelx.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart

index 2310733afec051dfe3f993d8b758ed52004b24f4..bcd02f59d4d866116e21b60e231488be6f8180a1 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_tracer.dart

@@ -330,11 +330,11 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {

String visitLiteralMap(LiteralMap node) {

List<String> entries = new List<String>();

- for (int i = 0; i < node.values.length; ++i) {

- String key = visitExpression(node.keys[i]);

- String value = visitExpression(node.values[i]);

+ node.entries.forEach((LiteralMapEntry entry) {

+ String key = visitExpression(entry.key);

+ String value = visitExpression(entry.value);

entries.add("$key: $value");

- }

+ });

return "map [${entries.join(', ')}]";

}