sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart - Issue 658103003: Support map and list literals in analyzer2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart

Issue 658103003: Support map and list literals in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use LiteralMapEntry to ensure build order Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart

diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart

index 2b17918394fa56e76eaaa0278c4781c1244fed6b..5169ee7d73abbd3bab86fcd471603c4b19c8b736 100644

--- a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart

+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart

@@ -177,8 +177,9 @@ class SExpressionStringifier extends Visitor<String> with Indentation {

}

String visitLiteralMap(LiteralMap node) {

- String keys = node.keys.map((v) => names[v.definition]).join(' ');

- String values = node.values.map((v) => names[v.definition]).join(' ');

+ String keys = node.entries.map((e) => names[e.key.definition]).join(' ');

+ String values =

+ node.entries.map((e) => names[e.value.definition]).join(' ');

return '(LiteralMap ($keys) ($values))';

}