Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654903002: Remove ResolutionEnqueuer.isLive (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove ResolutionEnqueuer.isLive BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41119

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -49 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 8 chunks +12 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/interceptor_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/universe.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/world.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/instantiated_classes_test.dart View 1 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
6 years, 2 months ago (2014-10-14 13:47:38 UTC) #3
floitsch
LGTM.
6 years, 2 months ago (2014-10-14 14:20:51 UTC) #4
Johnni Winther
Committed patchset #2 (id:40001) manually as 41119 (presubmit successful).
6 years, 2 months ago (2014-10-15 10:31:17 UTC) #5
floitsch
6 years, 2 months ago (2014-10-15 14:37:39 UTC) #6
Message was sent while issue was closed. 
On 2014/10/15 10:31:17, Johnni Winther wrote:
> Committed patchset #2 (id:40001) manually as 41119 (presubmit successful).

This commit broke the dummy_compiler_test.
I believe it's a bug in the type-inferrer.
python tools/test.py --host-checked -rd8 -cdart2js -mrelease -t960
utils/dummy_compiler_test

Powered by Google App Engine
This is Rietveld 408576698