Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 654903002: Remove ResolutionEnqueuer.isLive (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add test. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 75e1c980b66c6d421c4a23e148da32143972b1e5..4c5a6a9d91e0933121326779a54db10c7279f816 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -3200,6 +3200,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
});
registry.registerStaticUse(redirectionTarget);
+ // TODO(johnniwinther): Register the effective target type instead.
registry.registerInstantiatedClass(
redirectionTarget.enclosingClass.declaration);
if (isSymbolConstructor) {
@@ -3297,6 +3298,8 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
compiler.reportError(node.send.selector,
MessageKind.TYPE_VARIABLE_IN_CONSTANT);
}
+ // TODO(johniwinther): Avoid registration of `type` in face of redirecting
+ // factory constructors.
registry.registerInstantiatedType(type);
if (constructor.isFactoryConstructor && !type.typeArguments.isEmpty) {
registry.registerFactoryWithTypeArguments();

Powered by Google App Engine
This is Rietveld 408576698