sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 654903002: Remove ResolutionEnqueuer.isLive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 654903002: Remove ResolutionEnqueuer.isLive (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add test. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index 874afa9d64d903991028148b045f91b6f378f930..a1bcf0553afa6ed6bb1b02a00a4d5da3a29c47cf 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -171,8 +171,8 @@ class CodeEmitterTask extends CompilerTask {

// TODO(sigurdm): We should track those constants.

constantUnit = compiler.deferredLoadTask.mainOutputUnit;

}

- outputConstantLists.putIfAbsent(constantUnit, () => new List<ConstantValue>())

- .add(constant);

+ outputConstantLists.putIfAbsent(

+ constantUnit, () => new List<ConstantValue>()).add(constant);

}

@@ -186,8 +186,8 @@ class CodeEmitterTask extends CompilerTask {

// Compute needed classes.

Set<ClassElement> instantiatedClasses =

- compiler.codegenWorld.instantiatedClasses.where(computeClassFilter())

- .toSet();

+ compiler.codegenWorld.directlyInstantiatedClasses

+ .where(computeClassFilter()).toSet();

void addClassWithSuperclasses(ClassElement cls) {

neededClasses.add(cls);