Issue 64723002: VM: Fix identical comparisons with bigints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64723002: VM: Fix identical comparisons with bigints. (Closed)

Created:
7 years, 1 month ago by fschneider

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix identical comparisons with bigints. The optimizing compiler did not properly preserve registers across the runtime call that occurs when using identical with bigints. BUG=http://dartbug.com/14903 TEST=tests/language/vm/regress_14903_test.dart R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30058

Patch Set 1 #

Patch Set 2 : fixed MIPS #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -43 lines)			Patch
M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		2 chunks	+3 lines, -11 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	3 chunks	+3 lines, -16 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View		2 chunks	+4 lines, -9 lines	0 comments	Download
A	tests/language/vm/regress_14903_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM If this causes performance degradation we could save/restore registers explicitly across the leaf call ...

7 years, 1 month ago (2013-11-07 16:46:00 UTC) #2

fschneider

7 years, 1 month ago (2013-11-07 17:27:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30058 (presubmit successful).

Expand Messages | Collapse Messages