Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: runtime/vm/stub_code_ia32.cc

Issue 64723002: VM: Fix identical comparisons with bigints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed MIPS Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 2170 matching lines...) Expand 10 before | Expand all | Expand 10 after
2181 const Register left = EAX; 2181 const Register left = EAX;
2182 const Register right = EDX; 2182 const Register right = EDX;
2183 const Register temp = ECX; 2183 const Register temp = ECX;
2184 __ movl(left, Address(ESP, 2 * kWordSize)); 2184 __ movl(left, Address(ESP, 2 * kWordSize));
2185 __ movl(right, Address(ESP, 1 * kWordSize)); 2185 __ movl(right, Address(ESP, 1 * kWordSize));
2186 GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp); 2186 GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp);
2187 __ ret(); 2187 __ ret();
2188 } 2188 }
2189 2189
2190 2190
2191 // Called from otpimzied code only. Must preserve any registers that are 2191 // Called from optimized code only.
2192 // destroyed.
2193 // TOS + 0: return address 2192 // TOS + 0: return address
2194 // TOS + 1: right argument. 2193 // TOS + 1: right argument.
2195 // TOS + 2: left argument. 2194 // TOS + 2: left argument.
2196 // Returns ZF set. 2195 // Returns ZF set.
2197 void StubCode::GenerateOptimizedIdenticalWithNumberCheckStub( 2196 void StubCode::GenerateOptimizedIdenticalWithNumberCheckStub(
2198 Assembler* assembler) { 2197 Assembler* assembler) {
2199 const Register left = EAX; 2198 const Register left = EAX;
2200 const Register right = EDX; 2199 const Register right = EDX;
2201 const Register temp = ECX; 2200 const Register temp = ECX;
2202 // Preserve left, right and temp. 2201 __ movl(left, Address(ESP, 2 * kWordSize));
2203 __ pushl(left); 2202 __ movl(right, Address(ESP, 1 * kWordSize));
2204 __ pushl(right);
2205 __ pushl(temp);
2206 __ movl(left, Address(ESP, 5 * kWordSize));
2207 __ movl(right, Address(ESP, 4 * kWordSize));
2208 GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp); 2203 GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp);
2209 __ popl(temp);
2210 __ popl(right);
2211 __ popl(left);
2212 __ ret(); 2204 __ ret();
2213 } 2205 }
2214 2206
2215 } // namespace dart 2207 } // namespace dart
2216 2208
2217 #endif // defined TARGET_ARCH_IA32 2209 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698