Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 64723002: VM: Fix identical comparisons with bigints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed MIPS Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_mips.cc
===================================================================
--- runtime/vm/stub_code_mips.cc (revision 30047)
+++ runtime/vm/stub_code_mips.cc (working copy)
@@ -2400,7 +2400,6 @@
const Register temp2 = T3;
const Register left = T1;
const Register right = T0;
- // Preserve left, right.
__ lw(left, Address(SP, 1 * kWordSize));
__ lw(right, Address(SP, 0 * kWordSize));
GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp1, temp2);
@@ -2408,8 +2407,7 @@
}
-// Called from otpimzied code only. Must preserve any registers that are
-// destroyed.
+// Called from optimized code only.
// SP + 4: left operand.
// SP + 0: right operand.
// Returns: CMPRES1 is zero if equal, non-zero otherwise.
@@ -2419,21 +2417,10 @@
const Register temp2 = T3;
const Register left = T1;
const Register right = T0;
- // Preserve left, right.
- __ addiu(SP, SP, Immediate(-4 * kWordSize));
- __ sw(temp1, Address(SP, 3 * kWordSize));
- __ sw(temp2, Address(SP, 2 * kWordSize));
- __ sw(left, Address(SP, 1 * kWordSize));
- __ sw(right, Address(SP, 0 * kWordSize));
- __ lw(left, Address(SP, 5 * kWordSize));
- __ lw(right, Address(SP, 4 * kWordSize));
- GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp1, temp2);
- __ lw(right, Address(SP, 0 * kWordSize));
__ lw(left, Address(SP, 1 * kWordSize));
- __ lw(temp2, Address(SP, 2 * kWordSize));
- __ lw(temp1, Address(SP, 3 * kWordSize));
+ __ lw(right, Address(SP, 0 * kWordSize));
+ GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp1, temp2);
__ Ret();
- __ delay_slot()->addiu(SP, SP, Immediate(4 * kWordSize));
}
} // namespace dart
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698