Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 630093004: Fix 32-bit and 64-bit carry out calculation in arm64 simulator. (Closed)

Created:
6 years, 2 months ago by regis
Modified:
6 years, 2 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix 32-bit and 64-bit carry out calculation in arm64 simulator. Add support for 32-bit and 64-bit addition/subtraction with carry on simarm64. Add assembler tests. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=40989

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -104 lines) Patch
M runtime/vm/assembler_arm64.h View 1 3 chunks +53 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 1 chunk +102 lines, -0 lines 0 comments Download
M runtime/vm/constants_arm64.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 7 chunks +84 lines, -98 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
6 years, 2 months ago (2014-10-07 15:22:49 UTC) #2
zra
lgtm! also verified on hardware. https://codereview.chromium.org/630093004/diff/1/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/630093004/diff/1/runtime/vm/simulator_arm64.cc#newcode954 runtime/vm/simulator_arm64.cc:954: return (result >> 31) ...
6 years, 2 months ago (2014-10-07 16:27:50 UTC) #3
regis
On 2014/10/07 16:27:50, zra wrote: > lgtm! > > also verified on hardware. > > ...
6 years, 2 months ago (2014-10-08 07:21:31 UTC) #4
regis
6 years, 2 months ago (2014-10-08 07:22:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r40989 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698