Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 630033003: Adds ldp and stp instructions to ARM64. (Closed)

Created:
6 years, 2 months ago by zra
Modified:
6 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds ldp and stp instructions to ARM64. These should be used instead of single register load and store on frame entry and exit. I'll update these in another change. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40960

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -27 lines) Patch
M runtime/vm/assembler_arm64.h View 1 7 chunks +76 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M runtime/vm/constants_arm64.h View 6 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 6 chunks +78 lines, -23 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +96 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
6 years, 2 months ago (2014-10-06 23:35:42 UTC) #2
regis
LGTM
6 years, 2 months ago (2014-10-07 07:34:45 UTC) #3
zra
6 years, 2 months ago (2014-10-07 16:26:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r40960 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698