Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 628783002: Change integration test send...() methods to return structured objects. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change integration test send...() methods to return structured objects. This allows us to use completions when analyzing responses from the server in integration tests. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -223 lines) Patch
M pkg/analysis_server/lib/src/generated_protocol.dart View 16 chunks +16 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 13 chunks +84 lines, -41 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 3 chunks +26 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 26 chunks +68 lines, -68 lines 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 10 chunks +53 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 9 chunks +34 lines, -17 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 2 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-03 21:58:23 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-03 22:04:06 UTC) #3
scheglov
LGTM
6 years, 2 months ago (2014-10-03 22:22:17 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-04 17:37:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698