pkg/analysis_server/tool/spec/codegen_dart_protocol.dart - Issue 628783002: Change integration test send...() methods to return structured objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

Issue 628783002: Change integration test send...() methods to return structured objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

diff --git a/pkg/analysis_server/tool/spec/codegen_dart_protocol.dart b/pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

index 038d3b9c3b8a0c6966db2c8a9932972f2e8b7ca8..7a59bc725b2694f61bb81a74c43625124263c382 100644

--- a/pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

+++ b/pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

@@ -1230,7 +1230,8 @@ class CodegenProtocolVisitor extends DartCodegenVisitor with CodeGenerator {

inputType = 'Response';

inputName = 'response';

fieldName = '_result';

- makeDecoder = 'new ResponseDecoder(response)';

+ makeDecoder =

+ 'new ResponseDecoder(REQUEST_ID_REFACTORING_KINDS.remove(response.id))';

constructorName = 'fromResponse';

break;

case 'notificationParams':

« no previous file with comments | « pkg/analysis_server/test/protocol_test.dart ('k') | pkg/analysis_server/tool/spec/codegen_inttest_methods.dart » ('j') | no next file with comments »