Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: pkg/analysis_server/test/integration/analysis/get_errors.dart

Issue 628783002: Change integration test send...() methods to return structured objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.integration.analysis.get.errors; 5 library test.integration.analysis.get.errors;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:unittest/unittest.dart'; 9 import 'package:unittest/unittest.dart';
10 10
11 import '../integration_tests.dart'; 11 import '../integration_tests.dart';
12 12
13 /** 13 /**
14 * Base class for testing the "analysis.getErrors" request. 14 * Base class for testing the "analysis.getErrors" request.
15 */ 15 */
16 class AnalysisDomainGetErrorsTest extends 16 class AnalysisDomainGetErrorsTest extends AbstractAnalysisServerIntegrationTest
17 AbstractAnalysisServerIntegrationTest { 17 {
18 /** 18 /**
19 * True if the "analysis.getErrors" request should be made after analysis is 19 * True if the "analysis.getErrors" request should be made after analysis is
20 * complete. 20 * complete.
21 */ 21 */
22 final bool afterAnalysis; 22 final bool afterAnalysis;
23 23
24 AnalysisDomainGetErrorsTest(this.afterAnalysis); 24 AnalysisDomainGetErrorsTest(this.afterAnalysis);
25 25
26 test_getErrors() { 26 test_getErrors() {
27 String pathname = sourcePath('test.dart'); 27 String pathname = sourcePath('test.dart');
28 String text = r''' 28 String text = r'''
29 main() { 29 main() {
30 var x // parse error: missing ';' 30 var x // parse error: missing ';'
31 }'''; 31 }''';
32 writeFile(pathname, text); 32 writeFile(pathname, text);
33 standardAnalysisSetup(); 33 standardAnalysisSetup();
34 Future finishTest() { 34 Future finishTest() {
35 return sendAnalysisGetErrors(pathname).then((result) { 35 return sendAnalysisGetErrors(pathname).then((result) {
36 expect(result['errors'], equals(currentAnalysisErrors[pathname])); 36 expect(
37 result.errors.map((error) => error.toJson()),
38 equals(currentAnalysisErrors[pathname]));
37 }); 39 });
38 } 40 }
39 if (afterAnalysis) { 41 if (afterAnalysis) {
40 return analysisFinished.then((_) => finishTest()); 42 return analysisFinished.then((_) => finishTest());
41 } else { 43 } else {
42 return finishTest(); 44 return finishTest();
43 } 45 }
44 } 46 }
45 } 47 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/protocol.dart ('k') | pkg/analysis_server/test/integration/analysis/get_hover_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698